This repository was archived by the owner on Mar 11, 2026. It is now read-only.
refactor(ts): convert tests to typescript#282
Merged
JustinBeckwith merged 3 commits intogoogleapis:masterfrom Oct 28, 2018
JustinBeckwith:tst
Merged
refactor(ts): convert tests to typescript#282JustinBeckwith merged 3 commits intogoogleapis:masterfrom JustinBeckwith:tst
JustinBeckwith merged 3 commits intogoogleapis:masterfrom
JustinBeckwith:tst
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 12 12
Lines 633 633
Branches 60 60
=======================================
Hits 584 584
Misses 35 35
Partials 14 14
Continue to review full report at Codecov.
|
ofrobots
reviewed
Oct 28, 2018
| const proxyquire = require('proxyquire'); | ||
| import * as assert from 'assert'; | ||
| import * as extend from 'extend'; | ||
| import {Service, util} from '@google-cloud/common-grpc'; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| paginator: { | ||
| extend: function(Class, methods) { | ||
| if (Class.name !== 'Logging') { | ||
| extend(c, methods) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| const {v2} = require('../src'); | ||
| const PKG = require('../../package.json'); | ||
|
|
||
| const g: {[index: string]: boolean} = global as {}; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@ofrobots ready for another look |
Contributor
|
Lgtm
…On Sun, Oct 28, 2018, 11:31 AM Justin Beckwith ***@***.***> wrote:
@ofrobots <https://github.com/ofrobots> ready for another look
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#282 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE0qYwUT24XiCeRU1cC3ZwhN6F2DzQqks5upff8gaJpZM4X92-i>
.
|
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #260
Fixes #261