This repository was archived by the owner on Mar 11, 2026. It is now read-only.
chore(typescript): convert src/ to typescript#258
Merged
JustinBeckwith merged 3 commits intogoogleapis:masterfrom Oct 23, 2018
JustinBeckwith:ts1
Merged
chore(typescript): convert src/ to typescript#258JustinBeckwith merged 3 commits intogoogleapis:masterfrom JustinBeckwith:ts1
JustinBeckwith merged 3 commits intogoogleapis:masterfrom
JustinBeckwith:ts1
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
==========================================
- Coverage 98.15% 91.84% -6.32%
==========================================
Files 15 9 -6
Lines 2497 601 -1896
Branches 0 58 +58
==========================================
- Hits 2451 552 -1899
+ Misses 46 35 -11
- Partials 0 14 +14
Continue to review full report at Codecov.
|
ofrobots
approved these changes
Oct 23, 2018
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
I was working on the same thing (but without the noImplicitAny), but you beat me to it.
It is the right call to use noImplicitAny as a first step.
Contributor
Author
|
Rats. I went ahead and created tracking issues so we don't step on each other's toes :) . I'll assign stuff to myself before workin on it :) |
jkwlui
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.