This repository was archived by the owner on Mar 11, 2026. It is now read-only.
refactor: remove async, methmeth, propprop#253
Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom Oct 22, 2018
JustinBeckwith:async-system
Merged
refactor: remove async, methmeth, propprop#253JustinBeckwith merged 1 commit intogoogleapis:masterfrom JustinBeckwith:async-system
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:async-system
Conversation
googlebot
added
the
cla: yes
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=========================================
Coverage ? 98.15%
=========================================
Files ? 15
Lines ? 2497
Branches ? 0
=========================================
Hits ? 2451
Misses ? 46
Partials ? 0
Continue to review full report at Codecov.
|
ofrobots
approved these changes
Oct 22, 2018
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Does that apply to js files too?
…On Mon, Oct 22, 2018, 8:32 AM Justin Beckwith ***@***.***> wrote:
Merged #253 <#253> into
master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#253 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE0qUKn5zn95MG-0RgD8l4WjuMHSYI9ks5uneUJgaJpZM4XyMQq>
.
|
Contributor
Author
|
Yes! I double checked, and the file in the build folder has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the system tests more towards async/await, while dropping a few dependencies along the way.