This repository was archived by the owner on Mar 11, 2026. It is now read-only.
Introduce middleware directory#248
Merged
JustinBeckwith merged 5 commits intogoogleapis:masterfrom Oct 28, 2018
Merged
Conversation
ghost
assigned
googlebot
added
the
cla: yes
ofrobots
added
the
do not merge
Contributor
Author
|
To spell out the pros/cons more clearly:
|
soldair
approved these changes
Oct 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=========================================
Coverage ? 92.25%
=========================================
Files ? 12
Lines ? 633
Branches ? 60
=========================================
Hits ? 584
Misses ? 35
Partials ? 14
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Oct 22, 2018
| * limitations under the License. | ||
| */ | ||
|
|
||
| export interface HttpRequest { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
force-pushed
the
make-middleware
branch
from
afb18b1 to
338558a
Compare
ofrobots
changed the title
Common code to be used by the logging-{winston,bunyan} libs.
ofrobots
force-pushed
the
make-middleware
branch
from
a217047 to
7292d14
Compare
ofrobots
removed
the
do not merge
Contributor
Author
|
Added tests. This is ready for review. @JustinBeckwith @soldair PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only pay attention to the last commit: 8fb1ba8. This depends on #246, so those commits show up here too – ignore them.We need to share code between
logging-{winston,bunyan}to support express (and in the future other frameworks) middleware. This PR contains a preview of what that would look like. This code will not be used locally, but will be used by bothlogging-{winston,bunyan}.@JustinBeckwith expressed that it he doesn't like the idea of a new module to share this code and would prefer if this went in here. I'm opening the issue now to get broader feedback from others before we go ahead too much on this path.
@stephenplusplus @DominicKramer @kinwa91 (and others intersted) PTAL. I'm interest what y'all think.