Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

refactor: introduce typescript compiler#246

Merged
ofrobots merged 1 commit intogoogleapis:masterfrom
ofrobots:to-ts
Oct 20, 2018
Merged

refactor: introduce typescript compiler#246
ofrobots merged 1 commit intogoogleapis:masterfrom
ofrobots:to-ts

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots commented Oct 19, 2018

Use TypeScript compiler with the allowJs option. With the toolchain
in place we can start migrating the files incrementally.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2018
@ghost ghost assigned ofrobots Oct 19, 2018
ofrobots
ofrobots commented Oct 19, 2018
View reviewed changes
Comment thread tsconfig.json
"outDir": "build",
"allowJs": true,
"declaration": false,
"skipLibCheck": true

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

JustinBeckwith
JustinBeckwith suggested changes Oct 19, 2018
View reviewed changes
Comment thread src/v2/config_service_v2_client.js
Comment thread src/v2/logging_service_v2_client.js
Comment thread src/v2/metrics_service_v2_client.js
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 19, 2018 •
edited
Loading

Codecov Report

Merging #246 into master will decrease coverage by 1.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage     100%   98.15%   -1.85%     
==========================================
  Files           5       15      +10     
  Lines         369     2493    +2124     
==========================================
+ Hits          369     2447    +2078     
- Misses          0       46      +46
Impacted Files Coverage Δ
src/v2/config_service_v2_client.js 85.86% <100%> (ø)
test/index.js 98.88% <100%> (ø)
src/v2/logging_service_v2_client.js 81.42% <100%> (ø)
src/index.js 100% <100%> (ø) ⬆️
src/v2/metrics_service_v2_client.js 85.48% <100%> (ø)
test/entry.js 98.97% <0%> (ø)
src/v2/index.js 100% <0%> (ø)
test/sink.js 100% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3453de...11c0f2e. Read the comment docs.

JustinBeckwith
JustinBeckwith reviewed Oct 19, 2018
View reviewed changes
Comment thread .eslintrc.yml Outdated
no-warning-comments: warn
no-var: error
prefer-const: error
node/no-missing-require: warn

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@JustinBeckwith
Copy link
Copy Markdown
Contributor

JustinBeckwith commented Oct 19, 2018

Approved assuming synth.py runs before, and CI all passes :)

@ofrobots
Copy link
Copy Markdown
Contributor Author

ofrobots commented Oct 19, 2018

Can someone confirm if the system tests were passing on kokoro before this PR?

@ofrobots ofrobots mentioned this pull request Oct 19, 2018
Merged
@ofrobots
refactor: introduce typescript compiler
11c0f2e 
Use TypeScript compiler with the `allowJs` option. With the toolchain
in place we can start migrating the files incrementally.
@ofrobots ofrobots merged commit d6f04a7 into googleapis:master Oct 20, 2018
@ofrobots ofrobots deleted the to-ts branch October 20, 2018 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ofrobots ofrobots

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ofrobots @JustinBeckwith @googlebot