build: write logs to separate file#230
build: write logs to separate file#230JustinBeckwith merged 2 commits intogoogleapis:masterfrom callmehiphop:dg--ci-fix
Conversation
googlebot
added
the
cla: yes
ghost
assigned
|
@callmehiphop Yeah... so 2 things there.
Thank you for digging into this. |
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM once comment is addressed.
|
|
||
| describe('logs', () => { | ||
| const log = logging.log('syslog'); | ||
| const log = logging.log('systestlog'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 369 369
=====================================
Hits 369 369Continue to review full report at Codecov.
|
4 participants
We're seeing some unexpected errors come up in our syslog file. This PR runs tests against a different log file to prevent unexpected results.
@JustinBeckwith I'm not sure if we should continue to dig into the error we're seeing, but it seems to be related to the CI environment and not the client library itself.