Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

fix(gce): instance id can be a big number#222

Merged
ofrobots merged 3 commits intogoogleapis:masterfrom
ofrobots:big-instance-id
Sep 15, 2018
Merged

fix(gce): instance id can be a big number#222
ofrobots merged 3 commits intogoogleapis:masterfrom
ofrobots:big-instance-id

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots commented Sep 14, 2018

Pick up latest gcp-metadata that changes the return value on instance queries.
In addition this version of gcp-metadata fixes silent integer precision loss when
the instance id is too big a number.

Pick-up an updated gcp-metadata that fixes silent integer precision
loss when the instance id is too big a number.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2018
@ghost ghost assigned ofrobots Sep 14, 2018
@ofrobots
Copy link
Copy Markdown
Contributor Author

I have manually verified this branch to correctly identify the GCE resource when running on GCE.
image

@ofrobots ofrobots merged commit 7b98bb7 into googleapis:master Sep 15, 2018
@ofrobots ofrobots deleted the big-instance-id branch September 15, 2018 00:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants