Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

docs: Documentation update for OpenTelemetry and tracing#1517

Merged
cindy-peng merged 7 commits intomainfrom
cindy/otel-doc
Jul 15, 2024
Merged

docs: Documentation update for OpenTelemetry and tracing#1517
cindy-peng merged 7 commits intomainfrom
cindy/otel-doc

Conversation

@cindy-peng
Copy link
Copy Markdown
Contributor

@cindy-peng cindy-peng commented Jul 11, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Please ignore Owlbot auto-commits for lint fixing and focus only on changes to https://github.com/googleapis/nodejs-logging/blob/bcf114654f6f16008741f85885230308aed5f318/.readme-partials.yml

Here is a preview for ReadMe rendering:

image

@cindy-peng cindy-peng requested review from a team and daniel-sanche July 11, 2024 21:17
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: logging Issues related to the googleapis/nodejs-logging API. labels Jul 11, 2024
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 11, 2024
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

@cindy-peng cindy-peng requested review from gkevinzheng and removed request for daniel-sanche July 11, 2024 22:46
Comment thread .readme-partials.yml Outdated
Comment thread .readme-partials.yml Outdated
Comment thread .readme-partials.yml Outdated
Comment thread .readme-partials.yml Outdated
Comment thread .readme-partials.yml Outdated
Comment thread .readme-partials.yml Outdated
Comment thread .readme-partials.yml Outdated
Copy link
Copy Markdown

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README changes LGTM

Copy link
Copy Markdown

@gkevinzheng gkevinzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cindy-peng cindy-peng merged commit a8c950d into main Jul 15, 2024
@cindy-peng cindy-peng deleted the cindy/otel-doc branch July 15, 2024 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants