This repository was archived by the owner on Mar 11, 2026. It is now read-only.
fix: Instrumentation version contains package.json content#1310
Merged
fix: Instrumentation version contains package.json content#1310
Conversation
product-auto-label
Bot
added
the
api: logging
ruyadorno
reviewed
Aug 19, 2022
ruyadorno
left a comment
ruyadorno
left a comment
There was a problem hiding this comment.
Just an optional suggestion to add a test, otherwise implementation LGTM 👍
ruyadorno
approved these changes
Aug 19, 2022
losalex
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
losalex
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In few cases when we retrieve the package version by calling getNodejsLibraryVersion the content from package.json is returned. This fix tries to retrieve version from JSON and returns 'unknown' value if version cannot be retrieved