Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

fix: Add LogSyncOptions parameter to Logging.logSync() API#1307

Merged
losalex merged 1 commit intomainfrom
losalex/fix-logsync-options
Jul 14, 2022
Merged

fix: Add LogSyncOptions parameter to Logging.logSync() API#1307
losalex merged 1 commit intomainfrom
losalex/fix-logsync-options

Conversation

@losalex
Copy link
Copy Markdown
Contributor

@losalex losalex commented Jul 14, 2022

Add an ability to transfer LogSyncOptions in Logging.logSync() API

@losalex losalex requested review from a team July 14, 2022 21:23
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Jul 14, 2022
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Jul 14, 2022
Copy link
Copy Markdown
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@losalex losalex merged commit 89408b0 into main Jul 14, 2022
@losalex losalex deleted the losalex/fix-logsync-options branch July 14, 2022 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants