This repository was archived by the owner on Mar 11, 2026. It is now read-only.
feat: Add support for library instrumentation#1261
Merged
Conversation
product-auto-label
Bot
added
size: l
losalex
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
arbrown
reviewed
May 2, 2022
minherz
reviewed
May 2, 2022
Contributor
minherz
left a comment
minherz
left a comment
There was a problem hiding this comment.
good work. maybe it worth to bring someone from Yoshi team for additional review.
arbrown
approved these changes
May 2, 2022
losalex
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
losalex
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
summer-ji-eng
approved these changes
May 6, 2022
Contributor
summer-ji-eng
left a comment
summer-ji-eng
left a comment
There was a problem hiding this comment.
But familiar with the business, but overall LGTM and left couple comments. Thank you:)
This was referenced May 27, 2022
|
Is it possible to disable "library instrumentation"? |
|
Or how can I hide this kind of entries in the log explorer? There are just too many of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature provides an ability to log extra entry with diagnostics structure which contains logging library information. Such entry is logged only once when first entry is written by a process using logging library.
Fixes #1286 🦕