Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

chore: add api_shortname and library_type to repo metadata#1201

Merged
gcf-merge-on-green[bot] merged 8 commits intomainfrom
update-repo-metadata
Jan 13, 2022
Merged

chore: add api_shortname and library_type to repo metadata#1201
gcf-merge-on-green[bot] merged 8 commits intomainfrom
update-repo-metadata

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Dec 28, 2021

Update .repo-metadata.json as required by go/library-data-integrity

@parthea parthea requested review from a team December 28, 2021 13:56
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Dec 28, 2021
Copy link
Copy Markdown
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Dec 30, 2021
Copy link
Copy Markdown
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address README related comment

@bcoe
Copy link
Copy Markdown

bcoe commented Dec 30, 2021

@losalex the logic for warning on README updates is giving a false positive in this case, the README is generated automatically from .repo-metadata.json, so this is not a manual change.

Copy link
Copy Markdown
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@losalex
Copy link
Copy Markdown
Contributor

losalex commented Dec 30, 2021

@losalex the logic for warning on README updates is giving a false positive in this case, the README is generated automatically from .repo-metadata.json, so this is not a manual change.

Sure, thanks @bcoe for clarification!

@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 54fdc3c into main Jan 13, 2022
@gcf-merge-on-green gcf-merge-on-green Bot deleted the update-repo-metadata branch January 13, 2022 16:44
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants