This repository was archived by the owner on Mar 11, 2026. It is now read-only.
fix: Setting maxEntrySize does not truncate big json payloads correctly#1177
Merged
fix: Setting maxEntrySize does not truncate big json payloads correctly#1177
Conversation
product-auto-label
Bot
added
the
api: logging
google-cla
Bot
added
the
cla: yes
minherz
suggested changes
Dec 23, 2021
Contributor
minherz
left a comment
minherz
left a comment
There was a problem hiding this comment.
please check for conditions that allow null.
minherz
approved these changes
Dec 24, 2021
minherz
approved these changes
Dec 24, 2021
Contributor
minherz
left a comment
minherz
left a comment
There was a problem hiding this comment.
Please address a null validation in line 1022 (see the discussion in review comments)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an ability to provide customized list of entries to be truncated. The list will be prepended to existing list of entries we truncate today by default, thus custom-defined fields will be truncated first
Fixes #1087 🦕