Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

feat: users can log formatted HTTPRequests#1085

Closed
freelerobot wants to merge 3 commits intomasterfrom
traceSpanDetect
Closed

feat: users can log formatted HTTPRequests#1085
freelerobot wants to merge 3 commits intomasterfrom
traceSpanDetect

Conversation

@freelerobot
Copy link
Copy Markdown
Contributor

@freelerobot freelerobot commented Jun 1, 2021

Changes:

  1. Users can now log.write(entry.metadata.requestObj), and get back a formatted GCP HTTPRequest log per LogEntry guidelines: https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry#httprequest
  2. Lifted make-http-requests out of /middleware subdirectories. Since it’s not just for middleware. Clean, as http-request was already in the main directory.

Prerequisite to: #1083

@freelerobot freelerobot self-assigned this Jun 1, 2021
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Jun 1, 2021
@freelerobot freelerobot added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 1, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2021
@freelerobot freelerobot changed the title feat: users can provide trace & span in writeOptions feat: users can log formatted HTTPRequests and X-Cloud-Trace-Context Jun 2, 2021
@freelerobot freelerobot changed the title feat: users can log formatted HTTPRequests and X-Cloud-Trace-Context feat: users can log formatted HTTPRequests Jun 2, 2021
@freelerobot freelerobot closed this Jun 3, 2021
gcf-owl-bot Bot added a commit that referenced this pull request Jan 13, 2022
Source-Link: googleapis/synthtool@4dfd20a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:2d850512335d7adca3a4b08e02f8e63192978aea88c042dacb3e382aa996ae7c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant