This repository was archived by the owner on Mar 11, 2026. It is now read-only.
fix(deps): remove dependency on through2#1023
Merged
freelerobot merged 4 commits intomasterfrom Apr 13, 2021
Merged
Conversation
product-auto-label
Bot
added
the
api: logging
google-cla
Bot
added
the
cla: yes
JustinBeckwith
changed the title
JustinBeckwith
added
the
do not merge
Codecov Report
@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
- Coverage 97.91% 97.89% -0.03%
==========================================
Files 18 18
Lines 13207 13224 +17
Branches 426 410 -16
==========================================
+ Hits 12932 12946 +14
- Misses 272 275 +3
Partials 3 3
Continue to review full report at Codecov.
|
JustinBeckwith
changed the title
JustinBeckwith
removed
the
do not merge
freelerobot
suggested changes
Apr 1, 2021
Contributor
There was a problem hiding this comment.
I tested on node10 and 14. Automation already defaults to testing on 12.
Results
- Node10 system test works
- Node10 sample test works
- Node14 system test works
- Node14 sample test works
@JustinBeckwith FYI the following 1 test failed in Node14
1) Logging
logs
log-specific entries
should list log entries as a stream:
Error: Timeout of 600000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/nicolezhu/Desktop/nodejs-logging/build/system-test/logging.js)
at listOnTimeout (internal/timers.js:554:17)
at processTimers (internal/timers.js:497:7)
Contributor
|
FYI: I will resolve this as a part of my Q2 OKR to reduce dependencies on node libraries Update: ran test on node 14 again, it's passing locally. might be a 1 time flake? |
freelerobot
added
priority: p2
freelerobot
approved these changes
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops the top level dependency on
through2, though it's still technically brought in via@google-cloud/commonand possiblypumpify. It moves us towards standard Transform and PassThrough streams instead of the wrapper on top. This is party of my "reduce all the dependencies" work.Note: this change is not without risk. We've tried this before, and run into issues. This library has solid system and sample tests - it would be super helpful if someone could run those system tests on node 10, 12, and 14, just to do a confidence check.