Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-logging
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v11.2.0
Choose a base ref
...
head repository: googleapis/nodejs-logging
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v11.2.1
Choose a head ref
  • 2 commits
  • 11 files changed
  • 4 contributors

Commits on Sep 3, 2025

  1. fix(logging): Specifying resourceNames should fetch logs only from th… 

    …ose resources (#1597)

* fix(logging): prevent project ID injection when resourceNames is set

When `getEntries` is called with a `resourceNames` array that specifies a logging bucket (particularly one in a
    different project), the library was incorrectly appending the current project's ID to the array.

This resulted in an invalid request, causing the Logging API to reject it with an `INVALID_ARGUMENT` error.

The fix adjusts the logic to only inject the default project ID if the `resourceNames` array is explicitly empty. This
    preserves the expected default behavior of searching within the current project, while respecting user-provided
    resource names for cross-project queries.

Fixes: #1593

* revert and add comment

* fix test

* by tests failure caused by node version

* resolve promisify dependency for node 14

* use relative path to avoid 429 error

* bypass unrelated doc check

---------

Co-authored-by: Baha Aiman <[email protected]>
    @cindy-peng @bhshkh
    cindy-peng and bhshkh authored Sep 3, 2025
    Configuration menu
    Copy the full SHA
    ff7899f View commit details
    Browse the repository at this point in the history

  2. chore(main): release 11.2.1 (#1598) 

    * chore(main): release 11.2.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    @release-please @gcf-owl-bot
    release-please[bot] and gcf-owl-bot[bot] authored Sep 3, 2025
    Configuration menu
    Copy the full SHA
    a53b8f8 View commit details
    Browse the repository at this point in the history
Loading