Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-logging
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: googleapis/nodejs-logging
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix/resource-name-other-projects-dan
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 29, 2025

  1. fix(logging): prevent project ID injection when resourceNames is set 

    When `getEntries` is called with a `resourceNames` array that specifies a logging bucket (particularly one in a
    different project), the library was incorrectly appending the current project's ID to the array.

This resulted in an invalid request, causing the Logging API to reject it with an `INVALID_ARGUMENT` error.

The fix adjusts the logic to only inject the default project ID if the `resourceNames` array is explicitly empty. This
    preserves the expected default behavior of searching within the current project, while respecting user-provided
    resource names for cross-project queries.

Fixes: #1593
    @bhshkh
    bhshkh committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    f8e2990 View commit details
    Browse the repository at this point in the history

  2. Add the new system test

    @danieljbruce
    danieljbruce committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    acfcae0 View commit details
    Browse the repository at this point in the history
Loading