fix: Runtime package.json check causes breakage when bundled (#1364)

losalex · web-flow · commit ec4023165368 · 2022-10-31T11:06:32.000-07:00
* fix: Runtime package.json check causes breakage when bundled

* Correct anoner place to return NODEJS_DEFAULT_LIBRARY_VERSION
diff --git a/src/utils/instrumentation.ts b/src/utils/instrumentation.ts
@@ -38,6 +38,7 @@ const maxDiagnosticValueLen = 14;
 export const DIAGNOSTIC_INFO_KEY = 'logging.googleapis.com/diagnostic';
 export const INSTRUMENTATION_SOURCE_KEY = 'instrumentation_source';
 export const NODEJS_LIBRARY_NAME_PREFIX = 'nodejs';
+export const NODEJS_DEFAULT_LIBRARY_VERSION = 'unknown';
 export const MAX_INSTRUMENTATION_COUNT = 3;
 export type InstrumentationInfo = {name: string; version: string};
 
@@ -174,7 +175,7 @@ function truncateValue(value: object | string, maxLen: number) {
   }
   // Return 'unknown' if version cannot be retrieved
   if (typeof value !== 'string') {
-    return 'unknown';
+    return NODEJS_DEFAULT_LIBRARY_VERSION;
   }
   if (value && value.length > maxLen) {
     return value.substring(0, maxLen).concat('*');
@@ -191,11 +192,15 @@ export function getNodejsLibraryVersion() {
   if (libraryVersion) {
     return libraryVersion;
   }
-  libraryVersion = require(path.resolve(
-    __dirname,
-    '../../../',
-    'package.json'
-  )).version;
+  try {
+    libraryVersion = require(path.resolve(
+      __dirname,
+      '../../../',
+      'package.json'
+    )).version;
+  } catch (err) {
+    libraryVersion = NODEJS_DEFAULT_LIBRARY_VERSION;
+  }
   return libraryVersion;
 }
 
