fix: log.write removed option.resource.labels (#1219)

losalex · web-flow · commit 6d7e9ed9cd8b · 2022-01-21T13:11:56.000-08:00
* fix: log.write removed option.resource.labels

* Add test for capital upper case letter
diff --git a/src/utils/log-common.ts b/src/utils/log-common.ts
@@ -57,12 +57,18 @@ export function snakecaseKeys(
   labels: {[p: string]: string} | null | undefined
 ) {
   for (const key in labels) {
+    const replaced = key.replace(
+      /[A-Z]/g,
+      letter => `_${letter.toLowerCase()}`
+    );
     Object.defineProperty(
       labels,
-      key.replace(/[A-Z]/g, letter => `_${letter.toLowerCase()}`),
+      replaced,
       Object.getOwnPropertyDescriptor(labels, key) as PropertyDescriptor
     );
-    delete labels[key];
+    if (replaced !== key) {
+      delete labels[key];
+    }
   }
   return labels;
 }
diff --git a/test/utils/log-common.ts b/test/utils/log-common.ts
@@ -99,11 +99,15 @@ describe('Log Common', () => {
       const labels = {
         projectId: 'id',
         fooBarBaz: 'foobar',
+        some_other: 'value',
+        AnotherOne: 'another',
       };
       const result = snakecaseKeys(labels);
       assert.deepStrictEqual(result, {
         project_id: 'id',
         foo_bar_baz: 'foobar',
+        some_other: 'value',
+        _another_one: 'another',
       });
     });
   });
