Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Add missing iam_policy proto#101

Merged
jkwlui merged 3 commits intogoogleapis:masterfrom
kepikoi:master
Jan 15, 2019
Merged

Add missing iam_policy proto#101
jkwlui merged 3 commits intogoogleapis:masterfrom
kepikoi:master

Conversation

@kepikoi
Copy link
Copy Markdown
Contributor

@kepikoi kepikoi commented Dec 20, 2018

Fixes #100

  • [ x] Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 20, 2018
@kepikoi
Copy link
Copy Markdown
Contributor Author

kepikoi commented Dec 20, 2018

I signed it

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 20, 2018
@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Jan 11, 2019

Hi kepikoi!

This shouldn't have been necessary if things are working as expected. This proto should be bundled in https://github.com/googleapis/nodejs-proto-files. Are you able to provide some code for us to reproduce the problem?

cc @alexander-fenster

@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Jan 11, 2019

Sorry, we just realized that you posted the reproduction in #100. Since this repository is generated using automated tools, we will look to fixing it upstream in the generator, otherwise the changes here could potentially be overwritten.

@jkwlui jkwlui added good first issue This issue is a good place to started contributing to this repository. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed good first issue This issue is a good place to started contributing to this repository. labels Jan 14, 2019
@jkwlui jkwlui added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2019
@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Jan 15, 2019

I'm going to merge this to unblock running nodejs-kms on Windows for now.

@jkwlui jkwlui merged commit d4fb697 into googleapis:master Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants