Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

feat: export AuthPlus#70

Merged
alexander-fenster merged 2 commits intomasterfrom
export-authplus-release-0.5.0
Jan 10, 2019
Merged

feat: export AuthPlus#70
alexander-fenster merged 2 commits intomasterfrom
export-authplus-release-0.5.0

Conversation

@alexander-fenster
Copy link
Copy Markdown
Contributor

@alexander-fenster alexander-fenster commented Jan 10, 2019

Export AuthPlus (copied from to make it possible to use it from google-api-nodejs-client micropackages, and release v0.5.0.

Copied from here:

https://github.com/googleapis/google-api-nodejs-client/blob/7e07d11f2c0573f70538adebf79d46f4e63515cd/src/googleapis.ts#L14-L26

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2019
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure to follow up by removing de-duplicating the code in the googleapis repo :)

@alexander-fenster alexander-fenster merged commit 4b4cd4a into master Jan 10, 2019
@alexander-fenster alexander-fenster deleted the export-authplus-release-0.5.0 branch January 10, 2019 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants