This repository was archived by the owner on Dec 16, 2025. It is now read-only.
fix(streams): reroute boundary insertion through transform stream#67
Merged
JustinBeckwith merged 7 commits intogoogleapis:masterfrom Jan 22, 2019
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
If it is OK to combine the functionality, then can add |
Contributor
Author
|
Will follow with Unit Test. |
ajaaym
added
the
kokoro:force-run
1 task
kokoro-team
removed
the
kokoro:force-run
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
I'm cool with this, but this is a very sensitive piece of code :) Please make sure before this lands that you:
- Add a unit test to ensure the desired behavior
npm linkthis change intogoogle-api-nodejs-client, and run through the file multipart upload samples to make sure everything still works. Once that's done - happy to approve!
Contributor
|
👋 any story on tests here? Would be awesome to see :) |
JustinBeckwith
changed the title
| const finale = `--${boundary}--`; | ||
| const rStream = new stream.PassThrough(); | ||
| const pStream = new ProgressStream(); | ||
| const bStream = new BoundaryStream(finale); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
JustinBeckwith
approved these changes
Jan 21, 2019
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This was referenced Jan 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-api-nodejs-client/issues/1354
Reroute
boundaryinsertion to the the end of the stream via transform stream.BoundaryStreamclass as extension oftransformstream.boundaryin the_flushmethod of theBoundaryStream.rStream.