This repository was archived by the owner on Dec 16, 2025. It is now read-only.
fix: Ensure Marshalled GaxiosResponse has all properties#605
Merged
Conversation
sofisl
approved these changes
May 23, 2025
sofisl
changed the title
GaxiosResponse has all propertiesGaxiosResponse has all properties
sofisl
approved these changes
May 23, 2025
| @@ -49,7 +50,12 @@ export function headersToClassicHeaders<T extends Record<string, string>>( | |||
| * @returns the GaxiosResponse with HTTP2-ready/compatible headers | |||
| */ | |||
| export function martialGaxiosResponse<T extends GaxiosResponse>(res?: T) { | |||
Contributor
There was a problem hiding this comment.
Suggested change
| export function martialGaxiosResponse<T extends GaxiosResponse>(res?: T) { | |
| export function marshallGaxiosResponse<T extends GaxiosResponse>(res?: T) { |
| }); | ||
| }); | ||
|
|
||
| describe('martialGaxiosResponse', () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| describe('martialGaxiosResponse', () => { | |
| describe('marshallGaxiosResponse', () => { |
| data: {}, | ||
| }); | ||
|
|
||
| const newRes = martialGaxiosResponse(gRes); |
Contributor
There was a problem hiding this comment.
Suggested change
| const newRes = martialGaxiosResponse(gRes); | |
| const newRes = marshallGaxiosResponse(gRes); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦕