This repository was archived by the owner on Dec 16, 2025. It is now read-only.
fix: Timeout type#528
Merged
danielbankhead merged 4 commits intomainfrom Oct 5, 2023
Merged
Conversation
danielbankhead
commented
Oct 3, 2023
| export interface SessionData { | ||
| session: http2.ClientHttp2Session; | ||
| timeoutHandle?: NodeJS.Timer; | ||
| timeoutHandle?: NodeJS.Timeout; |
Contributor
Author
There was a problem hiding this comment.
Typically, this would be considered a breaking change, however the existing type in itself is a bug and must be fixed as it is blocking all PRs in this library.
sofisl
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦕