Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Add additionalProperties to SchemaItem#34

Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
ajaaym:schema_properties
Oct 30, 2018
Merged

Add additionalProperties to SchemaItem#34
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
ajaaym:schema_properties

Conversation

@ajaaym
Copy link
Copy Markdown
Contributor

@ajaaym ajaaym commented Oct 30, 2018

Add missing additionalProperties to SchemaItem as a precursor to fix 1383

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@JustinBeckwith JustinBeckwith merged commit 103bfd7 into googleapis:master Oct 30, 2018
@ajaaym ajaaym mentioned this pull request Oct 30, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Poor Typings for Schema$InstanceAggregatedList

3 participants

@ajaaym @JustinBeckwith @googlebot