Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

feat!: require node 10 in engines field (see: https://github.com/googleapis/nodejs-googleapis-common/pull/239)#240

Merged
bcoe merged 1 commit intomasterfrom
fix-commit-history
Mar 30, 2020
Merged

feat!: require node 10 in engines field (see: https://github.com/googleapis/nodejs-googleapis-common/pull/239)#240
bcoe merged 1 commit intomasterfrom
fix-commit-history

Conversation

@bcoe
Copy link
Copy Markdown

@bcoe bcoe commented Mar 30, 2020

a commit was landed in #239 that had a typo in the conventional commit header so wasn't picked up by tooling.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2020
@bcoe bcoe force-pushed the fix-commit-history branch from c05decc to 66bcaac Compare March 30, 2020 17:51
@bcoe bcoe changed the title feat! require node 10 in engines field (see: #239) feat! require node 10 in engines field (see: https://github.com/googleapis/nodejs-googleapis-common/pull/239) Mar 30, 2020
@bcoe bcoe changed the title feat! require node 10 in engines field (see: https://github.com/googleapis/nodejs-googleapis-common/pull/239) feat!: require node 10 in engines field (see: https://github.com/googleapis/nodejs-googleapis-common/pull/239) Mar 30, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2020

Codecov Report

Merging #240 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   33.27%   33.27%           
=======================================
  Files           9        9           
  Lines        1067     1067           
  Branches       60       60           
=======================================
  Hits          355      355           
  Misses        712      712

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7a71e...66bcaac. Read the comment docs.

@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@bcoe bcoe merged commit f210ec1 into master Mar 30, 2020
@release-please release-please Bot mentioned this pull request Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants