Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

Commit d1d08cb

Browse files
feat: added support for k8s_version field (#128)
* feat: added support for k8s_version field docs: k8s_version field is not part of resource_options struct Clients now generate the V1 or V1beta1 CRD based on Kubernetes server version. PiperOrigin-RevId: 430496281 Source-Link: googleapis/googleapis@97cf70e Source-Link: https://github.com/googleapis/googleapis-gen/commit/9e753429777968b43e5661c25ef38565b5e231bf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWU3NTM0Mjk3Nzc5NjhiNDNlNTY2MWMyNWVmMzg1NjViNWUyMzFiZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 4557427 commit d1d08cb

4 files changed

Lines changed: 45 additions & 3 deletions

File tree

protos/google/cloud/gkehub/v1alpha2/membership.proto

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2021 Google LLC
1+
// Copyright 2022 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -305,6 +305,11 @@ message ResourceOptions {
305305
// This option should be set for clusters with Kubernetes apiserver versions
306306
// <1.16.
307307
bool v1beta1_crd = 2 [(google.api.field_behavior) = OPTIONAL];
308+
309+
// Major version of the Kubernetes cluster. This is only used to determine
310+
// which version to use for the CustomResourceDefinition resources,
311+
// `apiextensions/v1beta1` or`apiextensions/v1`.
312+
string k8s_version = 3 [(google.api.field_behavior) = OPTIONAL];
308313
}
309314

310315
// GkeCluster contains information specific to GKE clusters.
@@ -562,7 +567,8 @@ message DeleteMembershipRequest {
562567
message UpdateMembershipRequest {
563568
// Required. The Membership resource name in the format
564569
// `projects/*/locations/*/memberships/*`.
565-
string name = 1 [(google.api.field_behavior) = REQUIRED];
570+
string name = 1 [
571+
(google.api.field_behavior) = REQUIRED];
566572

567573
// Required. Mask of fields to update.
568574
google.protobuf.FieldMask update_mask = 2 [(google.api.field_behavior) = REQUIRED];
@@ -584,7 +590,8 @@ message UpdateMembershipRequest {
584590
message GenerateConnectManifestRequest {
585591
// Required. The Membership resource name the Agent will associate with, in the format
586592
// `projects/*/locations/*/memberships/*`.
587-
string name = 1 [(google.api.field_behavior) = REQUIRED];
593+
string name = 1 [
594+
(google.api.field_behavior) = REQUIRED];
588595

589596
// Optional. Namespace for GKE Connect agent resources. Defaults to `gke-connect`.
590597
//

protos/protos.d.ts

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos/protos.js

Lines changed: 22 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos/protos.json

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)