Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

Commit 79f9560

Browse files
feat: added support for k8s_version field (#130)
* feat: added support for k8s_version field docs: k8s_version field is not part of resource_options struct Clients now generate the V1 or V1beta1 CRD based on Kubernetes server version. PiperOrigin-RevId: 430569173 Source-Link: googleapis/googleapis@3c17193 Source-Link: https://github.com/googleapis/googleapis-gen/commit/ae784406e300bf1c56d50111338b9272fb0473b5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU3ODQ0MDZlMzAwYmYxYzU2ZDUwMTExMzM4YjkyNzJmYjA0NzNiNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent d1d08cb commit 79f9560

11 files changed

Lines changed: 235 additions & 156 deletions

protos/google/cloud/gkehub/v1beta1/membership.proto

Lines changed: 134 additions & 95 deletions
Large diffs are not rendered by default.

protos/protos.d.ts

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos/protos.js

Lines changed: 22 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos/protos.json

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

samples/generated/v1beta1/gke_hub_membership_service.create_membership.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ function main(parent, membershipId, resource) {
2626
* TODO(developer): Uncomment these variables before running the sample.
2727
*/
2828
/**
29-
* Required. The parent (project and location) where the Memberships will be created.
30-
* Specified in the format `projects/* /locations/*`.
29+
* Required. The parent (project and location) where the Memberships will be
30+
* created. Specified in the format `projects/* /locations/*`.
3131
*/
3232
// const parent = 'abc123'
3333
/**
34-
* Required. Client chosen ID for the membership. `membership_id` must be a valid RFC
35-
* 1123 compliant DNS label:
34+
* Required. Client chosen ID for the membership. `membership_id` must be a
35+
* valid RFC 1123 compliant DNS label:
3636
* 1. At most 63 characters in length
3737
* 2. It must consist of lower case alphanumeric characters or `-`
3838
* 3. It must start and end with an alphanumeric character

samples/generated/v1beta1/gke_hub_membership_service.generate_connect_manifest.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,17 @@ function main(name) {
2626
* TODO(developer): Uncomment these variables before running the sample.
2727
*/
2828
/**
29-
* Required. The Membership resource name the Agent will associate with, in the format
30-
* `projects/* /locations/* /memberships/*`.
29+
* Required. The Membership resource name the Agent will associate with, in
30+
* the format `projects/* /locations/* /memberships/*`.
3131
*/
3232
// const name = 'abc123'
3333
/**
3434
* Optional. The connect agent to generate manifest for.
3535
*/
3636
// const connectAgent = {}
3737
/**
38-
* Optional. The Connect agent version to use. Defaults to the most current version.
38+
* Optional. The Connect agent version to use. Defaults to the most current
39+
* version.
3940
*/
4041
// const version = 'abc123'
4142
/**

samples/generated/v1beta1/gke_hub_membership_service.list_memberships.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ function main(parent) {
2626
* TODO(developer): Uncomment these variables before running the sample.
2727
*/
2828
/**
29-
* Required. The parent (project and location) where the Memberships will be listed.
30-
* Specified in the format `projects/* /locations/*`.
29+
* Required. The parent (project and location) where the Memberships will be
30+
* listed. Specified in the format `projects/* /locations/*`.
3131
*/
3232
// const parent = 'abc123'
3333
/**
34-
* Optional. When requesting a 'page' of resources, `page_size` specifies number of
35-
* resources to return. If unspecified or set to 0, all resources will
36-
* be returned.
34+
* Optional. When requesting a 'page' of resources, `page_size` specifies
35+
* number of resources to return. If unspecified or set to 0, all resources
36+
* will be returned.
3737
*/
3838
// const pageSize = 1234
3939
/**
@@ -43,8 +43,8 @@ function main(parent) {
4343
*/
4444
// const pageToken = 'abc123'
4545
/**
46-
* Optional. Lists Memberships that match the filter expression, following the syntax
47-
* outlined in https://google.aip.dev/160.
46+
* Optional. Lists Memberships that match the filter expression, following the
47+
* syntax outlined in https://google.aip.dev/160.
4848
* Examples:
4949
* - Name is `bar` in project `foo-proj` and location `global`:
5050
* name = "projects/foo-proj/locations/global/membership/bar"

samples/generated/v1beta1/gke_hub_membership_service.update_membership.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ function main(name, updateMask, resource) {
3131
*/
3232
// const name = 'abc123'
3333
/**
34-
* Required. Mask of fields to update. At least one field path must be specified in this
35-
* mask.
34+
* Required. Mask of fields to update. At least one field path must be
35+
* specified in this mask.
3636
*/
3737
// const updateMask = {}
3838
/**

samples/generated/v1beta1/gke_hub_membership_service.validate_exclusivity.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,19 @@ function main(parent, intendedMembership) {
2626
* TODO(developer): Uncomment these variables before running the sample.
2727
*/
2828
/**
29-
* Required. The parent (project and location) where the Memberships will be created.
30-
* Specified in the format `projects/* /locations/*`.
29+
* Required. The parent (project and location) where the Memberships will be
30+
* created. Specified in the format `projects/* /locations/*`.
3131
*/
3232
// const parent = 'abc123'
3333
/**
34-
* Optional. The YAML of the membership CR in the cluster. Empty if the membership
35-
* CR does not exist.
34+
* Optional. The YAML of the membership CR in the cluster. Empty if the
35+
* membership CR does not exist.
3636
*/
3737
// const crManifest = 'abc123'
3838
/**
39-
* Required. The intended membership name under the `parent`. This method only does
40-
* validation in anticipation of a CreateMembership call with the same name.
39+
* Required. The intended membership name under the `parent`. This method only
40+
* does validation in anticipation of a CreateMembership call with the same
41+
* name.
4142
*/
4243
// const intendedMembership = 'abc123'
4344

samples/generated/v1beta1/snippet_metadata.google.cloud.gkehub.v1beta1.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@
266266
"segments": [
267267
{
268268
"start": 25,
269-
"end": 73,
269+
"end": 74,
270270
"type": "FULL"
271271
}
272272
],
@@ -326,7 +326,7 @@
326326
"segments": [
327327
{
328328
"start": 25,
329-
"end": 62,
329+
"end": 63,
330330
"type": "FULL"
331331
}
332332
],

0 commit comments

Comments
 (0)