This repository was archived by the owner on Mar 4, 2026. It is now read-only.
feat: add ability to close channels#824
Merged
thebrianchen merged 8 commits intomasterfrom Dec 19, 2019
Merged
Conversation
googlebot
added
the
cla: yes
thebrianchen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
==========================================
- Coverage 90.35% 90.27% -0.08%
==========================================
Files 25 25
Lines 2820 2828 +8
Branches 707 708 +1
==========================================
+ Hits 2548 2553 +5
- Misses 119 122 +3
Partials 153 153
Continue to review full report at Codecov.
|
bcoe
changed the title
bcoe
changed the title
schmidt-sebastian
suggested changes
Dec 19, 2019
schmidt-sebastian
approved these changes
Dec 19, 2019
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
This looks good. @chenbrian is going to investigate what happens to snapshot listeners when terminate() is called. If the behavior is sane, we can merge and release.
schmidt-sebastian
approved these changes
Dec 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #769.