Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feature: Release the V1 Admin API#590

Merged
schmidt-sebastian merged 6 commits intomasterfrom
mrschmidt-v1admin
Mar 21, 2019
Merged

feature: Release the V1 Admin API#590
schmidt-sebastian merged 6 commits intomasterfrom
mrschmidt-v1admin

Conversation

@schmidt-sebastian
Copy link
Copy Markdown
Contributor

@schmidt-sebastian schmidt-sebastian commented Mar 21, 2019

We just published the configuration for the Firestore V1 Admin API to Github. This PR updates synthtool and update.sh to pull in the new configuration.

The manual changes in this PR are 6c3f1a0, 67a8430 and d8ea6a7.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2019
@schmidt-sebastian
Copy link
Copy Markdown
Contributor Author

schmidt-sebastian commented Mar 21, 2019

Linkinator is failing with two missing files:

[404] http://localhost:5294/google.firestore.admin.v1.html
[404] http://localhost:5294/google.longrunning.html

These are not generated by yarn docs, but I am struggling to find out why.

@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Mar 21, 2019

Added these docs via #591

jkwlui
jkwlui approved these changes Mar 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jkwlui jkwlui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved upon merging #591

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2019 •
edited
Loading

Codecov Report

Merging #590 into master will decrease coverage by 3.55%.
The diff coverage is 10.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   95.63%   92.07%   -3.56%     
==========================================
  Files          24       25       +1     
  Lines        1969     2057      +88     
  Branches      167      167              
==========================================
+ Hits         1883     1894      +11     
- Misses         65      142      +77     
  Partials       21       21
Impacted Files Coverage Δ
dev/src/v1/firestore_client.js 75% <ø> (ø) ⬆️
dev/src/v1/index.js 100% <100%> (ø) ⬆️
dev/src/v1/firestore_admin_client.js 7.05% <7.05%> (ø)
dev/src/watch.ts 99.1% <0%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b40355...173929f. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit acc2966 into master Mar 21, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-v1admin branch April 15, 2019 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jkwlui jkwlui jkwlui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkwlui jkwlui

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schmidt-sebastian @jkwlui @googlebot