refactor(typescript): enable noImplicitAny#553
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 95.85% 95.86% +<.01%
==========================================
Files 24 24
Lines 1932 1933 +1
Branches 168 168
==========================================
+ Hits 1852 1853 +1
Misses 57 57
Partials 23 23
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 95.85% 95.85% -0.01%
==========================================
Files 24 24
Lines 1932 1931 -1
Branches 168 168
==========================================
- Hits 1852 1851 -1
Misses 57 57
Partials 23 23
Continue to review full report at Codecov.
|
schmidt-sebastian
force-pushed
the
mrschmidt-noimplicitany
branch
from
8f92627 to
3eef758
Compare
| * document was read. | ||
| * @param encoding 'json' to indicate the format of `document` and `readTime`. | ||
| * @returns The QueryDocumentSnapshot with the document's data. | ||
| */ |
There was a problem hiding this comment.
Hrm. Duplicating all the docs for each overload like this seems a bit verbose and likely to get out-of-sync over time. Was there a particular motivation? I don't feel strongly, so feel free to leave as-is.
There was a problem hiding this comment.
This was mostly intended to get IntelliJ to stop warning me about missing docs for some of the arguments (since the overloads use different argument names). Since I wasn't 100% convinced of this when I did it, I removed this part of the changes. I did keep the overloads though.
JustinBeckwith
changed the title
3 participants
This removes
no-implicit-anyfrom the SDK.Fixes: #525