This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Finish TypeScript Migration (BREAKING CHANGE)#510
Closed
schmidt-sebastian wants to merge 27 commits intomasterfrom
Closed
Finish TypeScript Migration (BREAKING CHANGE)#510schmidt-sebastian wants to merge 27 commits intomasterfrom
schmidt-sebastian wants to merge 27 commits intomasterfrom
Conversation
85b6314 to
07a8bff
Compare
Contributor
Author
|
@JustinBeckwith / Node team: This PR fails CI with the following errors:
Note that |
This was referenced Dec 28, 2018
Closed
Merged
Merged
877b620 to
2373f67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finishes the Typescript migration of the Firestore Server SDK. As part of this:
unknowninstead ofanyfor the user-facing types (only internally, not in the types we shipped)isto be able to use TypeScript's typechecking.This is the PR that I am planning on merging, and it's also the PR that I am would like to address all feedback in (to reduce merge conflicts). Since it is not very easy to review, I split this out into a series of PRs that are more tightly scoped:
is#503 Cleanup: RemoveisThe individual PRs are not meant to compile/pass tests. There should not be anything in this larger PR (which should pass CI, fingers crossed) that is not part of the other PRs.
This is fairly low priority, so please take your time to review.
Fixes: b/117464450 and b/119350730