This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Cleanup: Remove is#503
Merged
JustinBeckwith merged 1 commit intomrschmidt-cleanupfrom Jan 14, 2019
Merged
Conversation
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-removeis
branch
from
4080fb5 to
7d74fe5
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-removeis
branch
from
ee73226 to
5ac3e52
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-removeis
branch
from
0cf58f2 to
97ef7bf
Compare
JustinBeckwith
approved these changes
Jan 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #512 but can be reviewed independently.
This PR removes the dependency on
isand moves all checks into the SDK itself. Whileisis nice library, it doesn't quite work with TypeScript type inference.