Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed the CLA docs

CLAs look good, thanks!

Hi @ushu! Thanks for doing this! While this should work for TypeScript users, it would be nice if we also cleaned up the SDK code itself (https://github.com/googleapis/nodejs-firestore/blob/master/dev/src/index.ts#L707 and https://github.com/googleapis/nodejs-firestore/blob/master/dev/src/transaction.ts#L161). Do you want to take a stab at that as well? Let us know if you are busy and we can take over :)

Note that the original intent of this signature was that to make it clear that the order of arguments is "DocumentReferences followed by field mask". This is probably not worth breaking our users over though... Thanks for catching this!

Superseded by #515.