This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Cleanup: Enforce Import ordering#498
Closed
schmidt-sebastian wants to merge 1 commit intomrschmidt-cleanupfrom
Closed
Cleanup: Enforce Import ordering#498schmidt-sebastian wants to merge 1 commit intomrschmidt-cleanupfrom
schmidt-sebastian wants to merge 1 commit intomrschmidt-cleanupfrom
Conversation
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-imports
branch
2 times, most recently
from
39ae600 to
fc1822b
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-imports
branch
from
fc1822b to
ff1b0a7
Compare
This was referenced Dec 28, 2018
yoshi-automation
added
🚨
JustinBeckwith
added
the
needs work
Contributor
Author
|
Merged as part of #512 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #512 but can be reviewed independently.
This PR cleans up all the imports for #510 and uses
tslintto enforce ordering. I manually moved the imports around to group them into cohesive blocks before invoking the linter.