This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Cleanup: Validate primitive types#496
Merged
JustinBeckwith merged 1 commit intomrschmidt-cleanupfrom Jan 14, 2019
Merged
Conversation
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-basictypes
branch
7 times, most recently
from
f54b223 to
bcee9ba
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-basictypes
branch
from
ce6f7c1 to
7a0e90a
Compare
JustinBeckwith
approved these changes
Jan 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #512 but can be reviewed independently.
This PR adds free-standing methods for the validation of simple types, such as boolean and strings. It uses an function argument to allow for optional values, instead of encoding this behavior in the method name (
isOptionalStringbecomesvalidateString(..., { optional: true ).The unused methods are removed in a follow-up PR.