This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Rejecting empty document IDs#44
Merged
schmidt-sebastian merged 5 commits intomasterfrom Oct 30, 2017
Merged
Conversation
Without this check, it was possible to get a CollectionReference by calling DocumentReference.doc() (and vice-versa). This addresses Google-internal issue https://b.corp.google.com/issues/64934977
googlebot
added
the
cla: yes
| assert.throws(() => { | ||
| collectionRef.doc(false); | ||
| }, /Argument "documentPath" is not a valid ResourcePath. Path is not a string./); | ||
| }, /Argument "documentPath" is not a valid ResourcePath. Path must be a non-empty strin./); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 1470 1470
=====================================
Hits 1470 1470
Continue to review full report at Codecov.
|
stephenplusplus
approved these changes
Oct 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this check, it was possible to get a CollectionReference by calling DocumentReference.doc() (and vice-versa).
This addresses Google-internal issue https://b.corp.google.com/issues/64934977