This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Regenerate library with synth.py customizations#345
Merged
JustinBeckwith merged 13 commits intomasterfrom Sep 11, 2018
Merged
Conversation
ghost
assigned
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Sep 11, 2018
| "build/src/*/v*/*.js", | ||
| "build/protos/*.js", | ||
| "build/test/**/*.js" | ||
| "src/*{/*,/**/*}.js", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Also, thank you for doing this @kinwa91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firestore had a number of unique pattern that warrants a customized
synth.py:/devconst client = require('@google-cloud/firestore').v1().jsdoc.jsneeds to pull source frombuild/system-test and samples-test can be verified in this branch (run-synth-system-tests):
https://circleci.com/gh/googleapis/workflows/nodejs-firestore/tree/run-synth-system-tests
(in-sync with this branch except enabling system/samples-test in .circleci configs)