Converting backoff.js to TypeScript by schmidt-sebastian · Pull Request #328 · googleapis/nodejs-firestore

schmidt-sebastian · 2018-08-24T17:52:27Z

No description provided.

codecov · 2018-08-24T17:54:46Z

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #328   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10      9    -1     
  Lines        1881   1838   -43     
  Branches      382    370   -12     
=====================================
- Hits         1881   1838   -43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca87ec...93deb66. Read the comment docs.

schmidt-sebastian · 2018-08-24T18:11:34Z

Sending this off for review. The Windows CI seems to be broken:

https://sponge.corp.google.com/target?id=40934a89-97d2-4694-a6a8-a945f217100a&target=cloud-devrel%2Fclient-libraries%2Fnodejs%2Fgoogleapis%2Fnodejs-firestore%2Fpresubmit%2Fnode8%2Flint&searchFor=

[11:01:04][ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Build config /tmp/workspace/workspace/cloud-devrel/client-libraries/nodejs/googleapis/nodejs-firestore/presubmit/node8/lint/src/github/nodejs-firestore/.kokoro/presubmit/node8/lint.cfg does not exist

hiranya911

Looks pretty good. Just a few minor things to adjust.

Sign in to view

 }

+/**
+ * Configuration object to adjust the delays of the exponential backoff


Sign in to view

+  private currentBaseMs = 0;
+
+  constructor(options: ExponentialBackoffOptions = {}) {
+    this.initialDelayMs = options.initialDelayMs !== undefined ?


Sign in to view

   */
-  _jitterDelayMs() {
-    return (Math.random() - 0.5) * this._jitterFactor * this._currentBaseMs;
+  private jitterDelayMs() {


Sign in to view

-    if (this._currentBaseMs < this._initialDelayMs) {
-      this._currentBaseMs = this._initialDelayMs;
+    this.currentBaseMs *= this.backoffFactor;
+    if (this.currentBaseMs < this.initialDelayMs) {


Sign in to view

-    if (this._currentBaseMs > this._maxDelayMs) {
-      this._currentBaseMs = this._maxDelayMs;
+    if (this.currentBaseMs > this.maxDelayMs) {
+      this.currentBaseMs = this.maxDelayMs;


schmidt-sebastian

Thanks for you review.

Sign in to view

 }

+/**
+ * Configuration object to adjust the delays of the exponential backoff


Sign in to view

+  private currentBaseMs = 0;
+
+  constructor(options: ExponentialBackoffOptions = {}) {
+    this.initialDelayMs = options.initialDelayMs !== undefined ?


Sign in to view

-    if (this._currentBaseMs < this._initialDelayMs) {
-      this._currentBaseMs = this._initialDelayMs;
+    this.currentBaseMs *= this.backoffFactor;
+    if (this.currentBaseMs < this.initialDelayMs) {


Sign in to view

-    if (this._currentBaseMs > this._maxDelayMs) {
-      this._currentBaseMs = this._maxDelayMs;
+    if (this.currentBaseMs > this.maxDelayMs) {
+      this.currentBaseMs = this.maxDelayMs;


Sign in to view

   */
-  _jitterDelayMs() {
-    return (Math.random() - 0.5) * this._jitterFactor * this._currentBaseMs;
+  private jitterDelayMs() {


codecov · 2018-08-31T20:57:11Z

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #328   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10      9    -1     
  Lines        1881   1838   -43     
  Branches      382    370   -12     
=====================================
- Hits         1881   1838   -43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0973006...833ec1c. Read the comment docs.

hiranya911

LGTM

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2018

ghost assigned schmidt-sebastian Aug 24, 2018

schmidt-sebastian force-pushed the convertbackoff branch from fda61ce to bb62f9c Compare August 24, 2018 17:54

schmidt-sebastian force-pushed the convertbackoff branch from bb62f9c to f8658a8 Compare August 24, 2018 17:55

Converting backoff.js to TypeScript

93deb66

schmidt-sebastian force-pushed the convertbackoff branch from f8658a8 to 93deb66 Compare August 24, 2018 18:00

Converting backoff.js to TypeScript

f3c8738

schmidt-sebastian requested a review from JustinBeckwith August 24, 2018 18:11

schmidt-sebastian assigned JustinBeckwith Aug 24, 2018

schmidt-sebastian assigned hiranya911 and unassigned JustinBeckwith and schmidt-sebastian Aug 31, 2018

schmidt-sebastian requested review from hiranya911 and removed request for JustinBeckwith August 31, 2018 19:16

hiranya911 suggested changes Aug 31, 2018

View reviewed changes

hiranya911 assigned schmidt-sebastian and unassigned hiranya911 Aug 31, 2018

Feedback

eabe2f8

schmidt-sebastian commented Aug 31, 2018

View reviewed changes

schmidt-sebastian assigned hiranya911 and unassigned schmidt-sebastian Aug 31, 2018

Merge

6b94bec

ghost assigned schmidt-sebastian Aug 31, 2018

Removing merge conflict marker

4a54bcd

hiranya911 approved these changes Aug 31, 2018

View reviewed changes

schmidt-sebastian added 2 commits August 31, 2018 14:00

Merge branch 'master' into convertbackoff

4d0509b

Merge branch 'master' into convertbackoff

833ec1c

schmidt-sebastian merged commit 21693c2 into master Sep 4, 2018

jmdobry deleted the convertbackoff branch October 16, 2018 19:33

snyk-bot mentioned this pull request Dec 5, 2019

[Snyk] Upgrade @google-cloud/firestore from 0.17.0 to 0.21.0 dyna-dot/g.gl_communityresources#8

Open

Conversation

schmidt-sebastian commented Aug 24, 2018

Uh oh!

codecov Bot commented Aug 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

schmidt-sebastian commented Aug 24, 2018

Uh oh!

hiranya911 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

schmidt-sebastian left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

codecov Bot commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hiranya911 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Aug 24, 2018 •

edited

Loading

codecov Bot commented Aug 31, 2018 •

edited

Loading