This repository was archived by the owner on Mar 4, 2026. It is now read-only.
change: pool.ts: add even more logging#2426
Merged
Conversation
The new/updated log messages are: * an "instance ID" for the ClientPool in each log message, to enable distinguishing log messages from distinct ClientPool instances. * the result of `this.activeClients.delete(client)` in ClientPool.release(), to ensure that it is, indeed, deleting an entry. * the active request count for each client in LazyLogStringForAllClientIds. * a message from ClientPool.terminate() that is unconditionally logged.
dconeybe
added
the
api: firestore
This reverts commit 25cd657.
MarkDuckworth
approved these changes
Sep 25, 2025
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
lgtm with question for your consideration
Contributor
Author
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PRs #2416 and #2420 to add even more logging to
ClientPool.The new/updated log messages include:
this.activeClients.delete(client)in ClientPool.release(), to ensure that it is, indeed, deleting an entry.This example log output shows what the log messages look like:
The motivation for this PR, and the previous #2416 and #2420 PRs, is to help investigate b/437011084, where ClientPool.acquire() apparently is returning previously-garbage-collected clients, resulting in "GoogleError: The client has already been closed".
BEGIN_COMMIT_OVERRIDE
fix: pool.ts: add even more logging
END_COMMIT_OVERRIDE