Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

chore: pin @google-cloud/promisify to legacy-14#2328

Merged
MarkDuckworth merged 2 commits intomainfrom
markduckworth/promisify-pin
Apr 9, 2025
Merged

chore: pin @google-cloud/promisify to legacy-14#2328
MarkDuckworth merged 2 commits intomainfrom
markduckworth/promisify-pin

Conversation

@MarkDuckworth
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@MarkDuckworth MarkDuckworth requested review from a team as code owners April 8, 2025 22:47
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Apr 8, 2025
@MarkDuckworth MarkDuckworth changed the title Pin @google-cloud/promisify to legacy-14 chore: pin @google-cloud/promisify to legacy-14 Apr 8, 2025
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Tested on my PR and unit tests are building fine.

@MarkDuckworth MarkDuckworth merged commit 948cce1 into main Apr 9, 2025
17 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/promisify-pin branch April 9, 2025 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants