Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: Enable tracing via OpenTelemetry.#2218

Merged
ehsannas merged 7 commits intomainfrom
ehsann/enable-tracing-wip
Dec 2, 2024
Merged

feat: Enable tracing via OpenTelemetry.#2218
ehsannas merged 7 commits intomainfrom
ehsann/enable-tracing-wip

Conversation

@ehsannas
Copy link
Copy Markdown
Contributor

@ehsannas ehsannas commented Oct 15, 2024

This PR enables the feature that allows users to capture Firestore trace spans by setting up an OpenTelemetry tracer and passing it to Firestore settings via settings.openTelemetry [or setting up a global OpenTelemetry tracer]. The feature can be disabled by setting the FIRESTORE_ENABLE_TRACING environment variable to OFF or FALSE.

@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Oct 15, 2024
@ehsannas ehsannas self-assigned this Oct 15, 2024
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Oct 15, 2024
@ehsannas ehsannas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 15, 2024
@ehsannas ehsannas requested a review from milaGGL October 15, 2024 04:00
@ehsannas ehsannas removed their assignment Oct 15, 2024
@ehsannas ehsannas marked this pull request as ready for review October 22, 2024 20:46
@ehsannas ehsannas requested review from a team October 22, 2024 20:46
Comment thread dev/src/telemetry/enabled-trace-util.ts Outdated
Comment thread types/firestore.d.ts Outdated
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 29, 2024
@ehsannas ehsannas requested a review from milaGGL October 29, 2024 19:41
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It will be nice if u can add PR description.

@ehsannas ehsannas added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 26, 2024
@ehsannas ehsannas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2024
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a line in the PR description that the public API has a name change, for future reference.

@ehsannas ehsannas merged commit 1ddb62e into main Dec 2, 2024
@ehsannas ehsannas deleted the ehsann/enable-tracing-wip branch December 2, 2024 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants