This repository was archived by the owner on Mar 4, 2026. It is now read-only.
build: fix path-to-regexp to older version due to node 14 requirement.#2187
Merged
build: fix path-to-regexp to older version due to node 14 requirement.#2187
Conversation
product-auto-label
Bot
added
the
api: firestore
MarkDuckworth
approved these changes
Sep 19, 2024
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
Unlikely to matter, but you could do "path-to-regexp": "^6.0.0". This would ensure we always have the latest v6.x.x release. Otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sinon depends on the nise package. That package just published v6.0.1 which updated path-to-regexp from v6.2.1 to v8.1.0 with sinonjs/nise#226. That should have been a major version bump, as this ended up introducing a breaking change that now it depends on Node >= 16, which is causing our CI to break.
This PR fixes path-to-regexp to ^6.2.1 like previously to make it work on Node >= 14
Similar to googleapis/nodejs-bigquery-storage#475 and googleapis/nodejs-bigquery#1403