Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

refactor: tracing using OpenTelemetry.#2085

Merged
ehsannas merged 6 commits intomainfrom
ehsann/otel-3
Jul 29, 2024
Merged

refactor: tracing using OpenTelemetry.#2085
ehsannas merged 6 commits intomainfrom
ehsann/otel-3

Conversation

@ehsannas
Copy link
Copy Markdown
Contributor

@ehsannas ehsannas commented Jul 15, 2024

No description provided.

@ehsannas ehsannas self-assigned this Jul 15, 2024
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jul 15, 2024
@ehsannas ehsannas force-pushed the ehsann/otel-3 branch 3 times, most recently from 2caf5b6 to 39a3957 Compare July 15, 2024 23:07
@ehsannas ehsannas requested a review from milaGGL July 16, 2024 21:16
@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Jul 16, 2024
@ehsannas ehsannas marked this pull request as ready for review July 16, 2024 21:16
@ehsannas ehsannas requested review from a team July 16, 2024 21:16
jimit-j-shah
jimit-j-shah reviewed Jul 16, 2024
View reviewed changes
Comment thread .idea/runConfigurations/System_Test.xml
milaGGL
milaGGL reviewed Jul 19, 2024
View reviewed changes
Comment thread dev/src/collection-group.ts
milaGGL
milaGGL reviewed Jul 19, 2024
View reviewed changes
Comment thread dev/src/index.ts
milaGGL
milaGGL reviewed Jul 19, 2024
View reviewed changes
Comment thread dev/system-test/tracing.ts Outdated
milaGGL
milaGGL reviewed Jul 19, 2024
View reviewed changes
Comment thread dev/system-test/tracing.ts Outdated
milaGGL
milaGGL reviewed Jul 19, 2024
View reviewed changes
Comment thread dev/system-test/tracing.ts
milaGGL
milaGGL reviewed Jul 19, 2024
View reviewed changes
Comment thread dev/system-test/tracing.ts
milaGGL
milaGGL reviewed Jul 23, 2024
View reviewed changes
Comment thread dev/src/telemetry/trace-util.ts
milaGGL
milaGGL reviewed Jul 23, 2024
View reviewed changes
Comment thread dev/src/reference/query-util.ts Outdated
milaGGL
milaGGL approved these changes Jul 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas changed the title feat: tracing using OpenTelemetry. refactor: tracing using OpenTelemetry. Jul 26, 2024
@ehsannas ehsannas merged commit e326e41 into main Jul 29, 2024
@ehsannas ehsannas deleted the ehsann/otel-3 branch July 29, 2024 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jimit-j-shah jimit-j-shah jimit-j-shah left review comments

@milaGGL milaGGL milaGGL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@milaGGL milaGGL

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehsannas @jimit-j-shah @milaGGL