Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: Expose the FindNearest.distance_result_field parameter#2067

Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom
owl-bot-copy
Aug 12, 2024
Merged

feat: Expose the FindNearest.distance_result_field parameter#2067
gcf-merge-on-green[bot] merged 2 commits intomainfrom
owl-bot-copy

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Jun 12, 2024 •
edited by MarkDuckworth
Loading

  • Regenerate this pull request now.

feat: Expose the FindNearest.distance_threshold parameter

PiperOrigin-RevId: 660557033

Source-Link: googleapis/googleapis@28685f7

Source-Link: https://github.com/googleapis/googleapis-gen/commit/38f25b0bcf54613758ed55a6390bc84e40368dc2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzhmMjViMGJjZjU0NjEzNzU4ZWQ1NWE2MzkwYmM4NGU0MDM2OGRjMiJ9

chore: expose new experimental FindNearest distance params to the preview branch
docs: minor documentation clarifications on FindNearest DistanceMeasure options

PiperOrigin-RevId: 655267922

Source-Link: googleapis/googleapis@7858db4

Source-Link: https://github.com/googleapis/googleapis-gen/commit/c0754282e8062565959b52391bb3addb870267b8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzA3NTQyODJlODA2MjU2NTk1OWI1MjM5MWJiM2FkZGI4NzAyNjdiOCJ9

feat: add bulk delete api
docs: update field api description

PiperOrigin-RevId: 642337904

Source-Link: googleapis/googleapis@9aab32e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/757cf9d8e2d139d7b2871ce013d5e2edc40176d3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzU3Y2Y5ZDhlMmQxMzlkN2IyODcxY2UwMTNkNWUyZWRjNDAxNzZkMyJ9

BEGIN_COMMIT_OVERRIDE
feat: Expose the proto changes to support FindNearest.distance_result_field parameter and the FindNearest.distance_threshold parameter
feat: Expose proto changes for the bulk delete api
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Jun 12, 2024
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 12, 2024
yoshi-approver
yoshi-approver previously approved these changes Jun 12, 2024
View reviewed changes
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Jun 12, 2024
@yoshi-approver yoshi-approver added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 12, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2024
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Jun 13, 2024

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 13, 2024
@gcf-owl-bot gcf-owl-bot Bot changed the title feat: add bulk delete api chore: expose new experimental FindNearest distance params to the preview branch Jul 23, 2024
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 23, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2024
@yoshi-approver yoshi-approver added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 23, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2024
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Jul 24, 2024

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 24, 2024
@gcf-owl-bot gcf-owl-bot Bot changed the title chore: expose new experimental FindNearest distance params to the preview branch feat: Expose the FindNearest.distance_result_field parameter Aug 8, 2024
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 8, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 8, 2024
@yoshi-approver yoshi-approver added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2024
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Aug 9, 2024

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 9, 2024
@gcf-owl-bot
Copy link
Copy Markdown
Contributor Author

gcf-owl-bot Bot commented Aug 12, 2024

Owl bot is regenerating pull request 2067...
Build name: NDdmMmRlZGEtMDRlYy00MmMxLWJlYzMtYWY3ZGI0NTdkZmVk

@yoshi-approver yoshi-approver added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 12, 2024
@gcf-owl-bot
feat: Expose the FindNearest.distance_result_field parameter
eb559f3 
feat: Expose the `FindNearest.distance_threshold` parameter

PiperOrigin-RevId: 660557033

Source-Link: googleapis/googleapis@28685f7

Source-Link: googleapis/googleapis-gen@38f25b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzhmMjViMGJjZjU0NjEzNzU4ZWQ1NWE2MzkwYmM4NGU0MDM2OGRjMiJ9

chore: expose new experimental FindNearest distance params to the preview branch
docs: minor documentation clarifications on FindNearest DistanceMeasure options

PiperOrigin-RevId: 655267922

Source-Link: googleapis/googleapis@7858db4

Source-Link: googleapis/googleapis-gen@c075428
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzA3NTQyODJlODA2MjU2NTk1OWI1MjM5MWJiM2FkZGI4NzAyNjdiOCJ9

feat: add bulk delete api
docs: update field api description

PiperOrigin-RevId: 642337904

Source-Link: googleapis/googleapis@9aab32e

Source-Link: googleapis/googleapis-gen@757cf9d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzU3Y2Y5ZDhlMmQxMzlkN2IyODcxY2UwMTNkNWUyZWRjNDAxNzZkMyJ9
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 12, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@MarkDuckworth MarkDuckworth marked this pull request as ready for review August 12, 2024 21:16
@MarkDuckworth MarkDuckworth requested review from a team August 12, 2024 21:16
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2024
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Aug 12, 2024 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 12, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2024
@gcf-merge-on-green gcf-merge-on-green Bot dismissed yoshi-approver’s stale review August 12, 2024 21:50

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green gcf-merge-on-green Bot merged commit 23ce891 into main Aug 12, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Aug 12, 2024
@gcf-merge-on-green gcf-merge-on-green Bot deleted the owl-bot-copy branch August 12, 2024 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@yoshi-approver yoshi-approver yoshi-approver left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. owl-bot-copy size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarkDuckworth @yoshi-approver @yoshi-kokoro