Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

fix: Add missing type for exposed database id#1996

Merged
MarkDuckworth merged 3 commits intogoogleapis:mainfrom
IchordeDionysos:fix/exported-type-database-id
Feb 16, 2024
Merged

fix: Add missing type for exposed database id#1996
MarkDuckworth merged 3 commits intogoogleapis:mainfrom
IchordeDionysos:fix/exported-type-database-id

Conversation

@IchordeDionysos
Copy link
Copy Markdown
Contributor

@IchordeDionysos IchordeDionysos commented Feb 3, 2024

Follow Up PR for #1937.

Defines the field in the Firestore types to be usable by end-users.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1936 🦕

@IchordeDionysos IchordeDionysos requested review from a team February 3, 2024 09:05
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Feb 3, 2024
@MarkDuckworth MarkDuckworth self-assigned this Feb 15, 2024
@MarkDuckworth MarkDuckworth added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 15, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2024
@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2024
@MarkDuckworth MarkDuckworth merged commit e967279 into googleapis:main Feb 16, 2024
@IchordeDionysos IchordeDionysos deleted the fix/exported-type-database-id branch February 16, 2024 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose databaseId and projectId on Firestore class

3 participants