Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

Firestore: Add test that verifies aggregate query error message when missing index#1960

Merged
dconeybe merged 5 commits intomainfrom
dconeybe/CountMissingIndexErrorMessageTest
Dec 15, 2023
Merged

Firestore: Add test that verifies aggregate query error message when missing index#1960
dconeybe merged 5 commits intomainfrom
dconeybe/CountMissingIndexErrorMessageTest

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

This verifies that the descriptive error message that occurs when the server does not have the required index has the URL that customers can follow to create the index.

This is a port of the "getCountFromServer error message is good if missing index" integration test from https://github.com/firebase/firebase-js-sdk/blob/42bfb0b8243a6c36b66a0bbedf61436e70591062/packages/firestore/test/integration/api/aggregation.test.ts#L130-L155 and firebase/firebase-android-sdk#4232.

Googlers see b/254063570 for details.

@dconeybe dconeybe self-assigned this Dec 14, 2023
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Dec 14, 2023
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Dec 15, 2023
@dconeybe dconeybe added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2023
@dconeybe dconeybe marked this pull request as ready for review December 15, 2023 04:03
@dconeybe dconeybe requested review from a team and milaGGL December 15, 2023 04:03
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants