This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Merged
Conversation
* WIP WIP. * also add isEqual. * lint. * add aggregate() API in firestore.d.ts. * Use NodeJS.Dict * Update isEqual. * Add isEqual unit test. * better api. * more tests. * Add more tests. * Remove test code that targets emulator. * rename avg() to average(). * rename avg to average. * Fix lint errors. * Clean up. * Address code review comments. * Expose aggregate type and field publicly. * Fix the way assert was imported. * lint. * backport test updates.
* feat: Add long-alias support for aggregations. * Lint fix and fix unit tests. * update assertion message.
* Enable tests. * Remove @internal annotation. * Address comments.
product-auto-label
Bot
added
size: xl
ehsannas
added
the
do not merge
MarkDuckworth
approved these changes
Aug 8, 2023
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
LGTM - two nits for you consideration.
markarndt
approved these changes
Aug 14, 2023
markarndt
approved these changes
Aug 16, 2023
ehsannas
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ehsannas
added
the
do not merge
ehsannas
removed
the
do not merge
ehsannas
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.