This repository was archived by the owner on Mar 4, 2026. It is now read-only.
feat: Add long-alias support for aggregations.#1844
Merged
ehsannas merged 3 commits intoehsann/sum-avgfrom Apr 27, 2023
Merged
Conversation
product-auto-label
Bot
added
size: m
MarkDuckworth
approved these changes
Apr 27, 2023
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
LGTM. I'm not very concerned about this difference in where the mapping is implemented in this SDK vs others. Generally the approach is the same, which is most important. The reason we are forced to implement this map in a different place is that the node.js SDK already has a different structure. If you're concerned, I think we could modify the other SDKs to have an implementation that's closer to this, but it would not be exact.
Contributor
Author
|
I agree with your reasoning. No need to update other SDKs to match this. |
ehsannas
added a commit
that referenced
this pull request
Aug 2, 2023
* feat: Add long-alias support for aggregations. * Lint fix and fix unit tests. * update assertion message.
ehsannas
added a commit
that referenced
this pull request
Oct 9, 2023
* feat: Sum and Average Aggregations. (#1831) * WIP WIP. * also add isEqual. * lint. * add aggregate() API in firestore.d.ts. * Use NodeJS.Dict * Update isEqual. * Add isEqual unit test. * better api. * more tests. * Add more tests. * Remove test code that targets emulator. * rename avg() to average(). * rename avg to average. * Fix lint errors. * Clean up. * Address code review comments. * Expose aggregate type and field publicly. * Fix the way assert was imported. * lint. * backport test updates. * feat: Add long-alias support for aggregations. (#1844) * feat: Add long-alias support for aggregations. * Lint fix and fix unit tests. * update assertion message. * Unhide APIs and enable tests (#1869) * Enable tests. * Remove @internal annotation. * Address comments. * Address comments. * Removing AggregateField.field from new api. * Fix failing test assertion with REST transport. * Fix test query. * Add more tests with cursors. * prettier. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Mark Duckworth <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.