This repository was archived by the owner on Mar 4, 2026. It is now read-only.
fix: enable REST numeric enums#1829
Merged
MarkDuckworth merged 3 commits intomainfrom Feb 28, 2023
Merged
Conversation
To use REST transport, pass {fallback: "rest"} to the client constructor.
PiperOrigin-RevId: 512747300
Source-Link: googleapis/googleapis@b0f2af1
Source-Link: googleapis/googleapis-gen@c986984
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzk4Njk4NDkwZWFiNzYwMzJkMjA2MDZlMjE0ZDMxMDM5NGU3OTMwZSJ9
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
Contributor
|
@MarkDuckworth This enables "numeric enums" feature back since the bug was fixed in google-gax. I'm bumping GAX version in this PR: the bug was fixed in 3.5.4, I'm setting to |
MarkDuckworth
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use REST transport, pass {fallback: "rest"} to the client constructor.
PiperOrigin-RevId: 512747300
Source-Link: googleapis/googleapis@b0f2af1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/c98698490eab76032d20606e214d310394e7930e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzk4Njk4NDkwZWFiNzYwMzJkMjA2MDZlMjE0ZDMxMDM5NGU3OTMwZSJ9